Expression#1092
Closed
saschasalles wants to merge 6 commits intopython:3.8from
saschasalles:expression
Closed
Conversation
Merged
awecx
suggested changes
Dec 14, 2019
awecx
left a comment
There was a problem hiding this comment.
Merci pour cette PR.
Je t'ai mis quelques remarques à la fin.
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
Contributor
|
@Sascha40 Le test en automatique dit qu'au moins une des lignes de ton fichier est maintenant trop longue (padpo doit aussi te le dire si tu le repasses). Tu peux tenter pour corriger cela : Tu peux aussi le corriger à la main si la correction est facile. Puis committer et pusher le résultat (n'oublie pas le pull avant tout ça, cf les diapos vues pendant l'atelier) |
|
Ping :-) |
Collaborator
|
Hello @Sascha40, ping ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1085
First pull request ever!